Bug 24094 - Cleanup leak messages on exit
Summary: Cleanup leak messages on exit
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-02-23 07:37 PST by Adam Treat
Modified: 2009-02-23 11:53 PST (History)
0 users

See Also:

Clean up leak messages (2.75 KB, patch)
2009-02-23 07:38 PST, Adam Treat
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2009-02-23 07:37:36 PST
Right now with the Qt port, WebCore::CachedResource is being leaked on exit.  This happens for every webpage that has a cached resource.  But that is ok, because WebCore::Cache itself is *designed* to be leaked on exit as it is a singleton.  However, WebCore::CachedResource has a RefCountedLeakMessage that prints on exit.

After consulting with Antti it was determined that the best thing the Qt port could do in this instance is match the Mac ports behavior.  This patch clears the cache on exit only in Debug builds in the same manner that the Mac port does.
Comment 1 Adam Treat 2009-02-23 07:38:14 PST
Created attachment 27880 [details]
Clean up leak messages
Comment 2 Darin Adler 2009-02-23 10:53:47 PST
Comment on attachment 27880 [details]
Clean up leak messages

Looks good. r=me
Comment 3 Adam Treat 2009-02-23 11:53:13 PST
Landed with r41151.