Bug 24090 - WorkerThreadableLoader needs to be able to post tasks for a mode.
Summary: WorkerThreadableLoader needs to be able to post tasks for a mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 22720
  Show dependency tree / graph
 
Reported: 2009-02-23 03:08 PST by David Levin
Modified: 2009-02-25 01:04 PST (History)
1 user (show)

See Also:

Attachments
Proposed fix. (13.02 KB, patch)
2009-02-23 03:11 PST, David Levin 		no flags Details | Formatted Diff | Diff
Proposed fix. (13.85 KB, patch)
2009-02-24 08:33 PST, David Levin 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-02-23 03:08:48 PST 
This will allow the sync xhr call done within a WorkerContext to get callbacks.
Comment 1 David Levin 2009-02-23 03:11:44 PST 
Created attachment 27877 [details]
Proposed fix.
Comment 2 David Levin 2009-02-24 08:33:35 PST 
Created attachment 27918 [details]
Proposed fix.
Comment 3 Alexey Proskuryakov 2009-02-24 09:03:56 PST 
Comment on attachment 27918 [details]
Proposed fix.

> +        Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.

What are those non-message tasks? How do we manage lifetime for them?
Comment 4 David Levin 2009-02-24 09:12:04 PST 
They are all part of xhr, so lifetime would be managed by xhr having pending activity.
Comment 5 Alexey Proskuryakov 2009-02-24 09:17:49 PST 
Comment on attachment 27918 [details]
Proposed fix.

> They are all part of xhr, so lifetime would be managed by xhr having pending
> activity.

That's what I expected, but it doesn't seem to be discoverable. How will someone adding a new kind of tasks learn that lifetime issues need to be resolved on a case by case basis?

r=me, by the way.
Comment 6 David Levin 2009-02-24 10:58:11 PST 
Committed as r41184.