RESOLVED FIXED Bug 24090
WorkerThreadableLoader needs to be able to post tasks for a mode.
https://bugs.webkit.org/show_bug.cgi?id=24090
Summary WorkerThreadableLoader needs to be able to post tasks for a mode.
David Levin
Reported 2009-02-23 03:08:48 PST
This will allow the sync xhr call done within a WorkerContext to get callbacks.
Attachments
Proposed fix. (13.02 KB, patch)
2009-02-23 03:11 PST, David Levin
no flags
Proposed fix. (13.85 KB, patch)
2009-02-24 08:33 PST, David Levin
ap: review+
David Levin
Comment 1 2009-02-23 03:11:44 PST
Created attachment 27877 [details] Proposed fix.
David Levin
Comment 2 2009-02-24 08:33:35 PST
Created attachment 27918 [details] Proposed fix.
Alexey Proskuryakov
Comment 3 2009-02-24 09:03:56 PST
Comment on attachment 27918 [details] Proposed fix. > + Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks. What are those non-message tasks? How do we manage lifetime for them?
David Levin
Comment 4 2009-02-24 09:12:04 PST
They are all part of xhr, so lifetime would be managed by xhr having pending activity.
Alexey Proskuryakov
Comment 5 2009-02-24 09:17:49 PST
Comment on attachment 27918 [details] Proposed fix. > They are all part of xhr, so lifetime would be managed by xhr having pending > activity. That's what I expected, but it doesn't seem to be discoverable. How will someone adding a new kind of tasks learn that lifetime issues need to be resolved on a case by case basis? r=me, by the way.
David Levin
Comment 6 2009-02-24 10:58:11 PST
Committed as r41184.
Note You need to log in before you can comment on or make changes to this bug.