Bug 240893 - Sequential WebVTT cues with the same contents can be dropped
Summary: Sequential WebVTT cues with the same contents can be dropped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-24 17:01 PDT by Jer Noble
Modified: 2022-05-26 16:26 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2022-05-24 17:01:49 PDT 
When a new cue is emitted from the parser that has the same contents and similar start time to an existing cue, it will be de-duplicated by dropping it. However, some encoders will split cues across WebVTT file boundaries and in this situation, valid cues are dropped.
Comment 1 Jer Noble 2022-05-24 17:06:14 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/996
Comment 2 EWS 2022-05-25 17:48:17 PDT 
Committed r294854 (250988@main): <https://commits.webkit.org/250988@main>

Reviewed commits have been landed. Closing PR #996 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-25 17:49:16 PDT 
<rdar://problem/93939179>