There are a number of flex-aspect ratio tests failing on wpt.fyi. The following tests are failing: flex-aspect-ratio-002 flex-aspect-ratio-004 flex-aspect-ratio-025 flex-aspect-ratio-026 https://wpt.fyi/results/css/css-sizing/aspect-ratio?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2021-aspect-ratio
<rdar://problem/93862854>
If you intend to work on this, we could collaborate. I did some patches for two of these in the past: https://bugs.webkit.org/show_bug.cgi?id=222357
Created attachment 461240 [details] Patch
Created attachment 461242 [details] Patch
Created attachment 461270 [details] Patch
Hi Rob, Which tests are your patches going to be addressing? I'm going to be starting work on the aspect-ratio issues again so I'll be making bug reports for each individual test.
Note https://github.com/w3c/csswg-drafts/issues/6794 which may change flex + aspect-ratio behavior.
(In reply to Sammy Gill from comment #6) > Hi Rob, > > Which tests are your patches going to be addressing? I'm going to be > starting work on the aspect-ratio issues again so I'll be making bug reports > for each individual test. Great! I was investigating and I think most flexbox test failures are due to the same root cause, not doing the right calculation for the content size suggestion, this probably applies to flex-aspect-ratio-002|004|025 and maybe even 038/039. The test flex-aspect-ratio-026.html has the most problems. One problem will be fixed by https://bugs.webkit.org/show_bug.cgi?id=243321. A remaining problem is that the width of some of the divs is 5px too wide, causing the green block to not be continuous. The final problem is when resizing a window, two of the divs will keep getting wider. When I disabled caching of child intrinsic sizes it did not have this bug but I think there were other issues. Feel free to ping me now and then if needed, these failures are longstanding so it would be cool to see them fixed.