Bug 240881 - Use the Clang .alt_entry directive to allow use of global labels in LLInt asm.
Summary: Use the Clang .alt_entry directive to allow use of global labels in LLInt asm.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-24 13:48 PDT by Mark Lam
Modified: 2022-05-24 14:57 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-05-24 13:48:58 PDT 
With this, debugging LLInt code will be easier.  LLInt code will no longer all be at an offset from vmEntryToJavaScript.  They will instead be broken up into different sections under human readable labels.

Secondly, crash traces of LLInt crashes will now be able to tell us give us the nearest label, as opposed to everything being an offset from vmEntryToJavaScript.
Comment 1 Mark Lam 2022-05-24 13:59:31 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/981
Comment 2 EWS 2022-05-24 14:56:36 PDT 
Committed r294768 (250933@main): <https://commits.webkit.org/250933@main>

Reviewed commits have been landed. Closing PR #981 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-24 14:57:14 PDT 
<rdar://problem/93860412>