Bug 240874 - Incorrect text set on PR description with multiple commits
Summary: Incorrect text set on PR description with multiple commits
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 240873 244116 (view as bug list)
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-24 08:25 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-09-15 11:43 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2022-05-24 08:25:51 PDT 
I pushed a PR with 3 commits for review:

They are titled

https://github.com/WebKit/WebKit/pull/968
P1. Rework SharedBufferCopy so that we can keep a reference to the underlying SharedMemory
P2. Remove SharedBufferCopy::safeBuffer() and rename SharedBufferCopy::buffer with SharedBufferCopy::unsafeBuffer.
P3. Rename SharedBufferCopy to SharedBufferReference

When pushed, the title of the PR becomes:
"P."

To add: Ideally it would be great if there was a "-m DESCRIPTION, --description=DESCRIPTION" like there was with webkit-patch
as the description can't always be the same as the patch on top of the stack.
Comment 1 Radar WebKit Bug Importer 2022-05-24 08:26:23 PDT 
<rdar://problem/93833985>
Comment 2 Alexey Proskuryakov 2022-05-24 13:22:02 PDT 
*** Bug 240873 has been marked as a duplicate of this bug. ***
Comment 3 Jonathan Bedard 2023-09-15 11:42:28 PDT 
This isn't really about the `P1/P2/P3`, it's just a problem about how we determine commit title when there are multiple commits. We're attempting to find the "common string" that all commits share in common.
Comment 4 Jonathan Bedard 2023-09-15 11:42:46 PDT 
*** Bug 244116 has been marked as a duplicate of this bug. ***