WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
240874
Incorrect text set on PR description with multiple commits
https://bugs.webkit.org/show_bug.cgi?id=240874
Summary
Incorrect text set on PR description with multiple commits
Jean-Yves Avenard [:jya]
Reported
2022-05-24 08:25:51 PDT
I pushed a PR with 3 commits for review: They are titled
https://github.com/WebKit/WebKit/pull/968
P1. Rework SharedBufferCopy so that we can keep a reference to the underlying SharedMemory P2. Remove SharedBufferCopy::safeBuffer() and rename SharedBufferCopy::buffer with SharedBufferCopy::unsafeBuffer. P3. Rename SharedBufferCopy to SharedBufferReference When pushed, the title of the PR becomes: "P." To add: Ideally it would be great if there was a "-m DESCRIPTION, --description=DESCRIPTION" like there was with webkit-patch as the description can't always be the same as the patch on top of the stack.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-05-24 08:26:23 PDT
<
rdar://problem/93833985
>
Alexey Proskuryakov
Comment 2
2022-05-24 13:22:02 PDT
***
Bug 240873
has been marked as a duplicate of this bug. ***
Jonathan Bedard
Comment 3
2023-09-15 11:42:28 PDT
This isn't really about the `P1/P2/P3`, it's just a problem about how we determine commit title when there are multiple commits. We're attempting to find the "common string" that all commits share in common.
Jonathan Bedard
Comment 4
2023-09-15 11:42:46 PDT
***
Bug 244116
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug