Bug 240870 - land-unsafe didn't update the commit log to add the reviewer
Summary: land-unsafe didn't update the commit log to add the reviewer
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-24 06:41 PDT by Claudio Saavedra
Modified: 2022-07-01 14:46 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2022-05-24 06:41:46 PDT 
claudio@weichafe:~/git/gnome/WebKit$ Tools/Scripts/webkit-patch land-unsafe --check-oops 
Logging in as csaavedra@igalia.com...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=240869&ctype=xml&excludefield=attachmentdata
Guessing "Adrian Perez de Castro" as reviewer from attachment 459721 [details] on bug 240869.
svn.webkit.org login: csaavedra@igalia.com
svn.webkit.org password for csaavedra@igalia.com: 

Committed r294743: <https://commits.webkit.org/r294743>
Adding comment and closing bug 240869
Closing bug 240869 as fixed

https://github.com/WebKit/WebKit/commit/2df4ae08c547cf7d8aceaa178d9da851996a9164
Comment 1 Claudio Saavedra 2022-05-24 06:43:00 PDT 
Also note that check-oops didn't do what I expected it to do..
Comment 2 Radar WebKit Bug Importer 2022-05-31 06:42:30 PDT 
<rdar://problem/94147990>
Comment 3 Jonathan Bedard 2022-07-01 14:46:09 PDT 
webkit-patch land-unsafe won't work now anyways, everything needs to go through Commit-Queue or Merge-Queue, closing this.