NEW 240837
Failing text-indent WPT tests 
https://bugs.webkit.org/show_bug.cgi?id=240837
Summary Failing text-indent WPT tests
Kiet Ho
Reported 2022-05-23 16:03:17 PDT
imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-flex-item-001.html imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-grid-item-001.html
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-05-23 19:30:49 PDT
*** Bug 240838 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 2 2022-05-30 16:04:13 PDT
<rdar://problem/94123786>
Ahmad Saleem
Comment 3 2023-10-01 16:54:57 PDT
We are still failing these test case. I think in IFC, we might have to do something here? InlineFormattingGeometry::computedTextIndent to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'?
zalan
Comment 4 2023-10-01 17:09:26 PDT
(In reply to Ahmad Saleem from comment #3) > We are still failing these test case. I think in IFC, we might have to do > something here? > > InlineFormattingGeometry::computedTextIndent > > to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'? Not quite, this is a bug in our "first formatted line" implementation where we assume the first child always produces a visible line (see setIsFirstChildForIntegration). Should be relatively easy to fix as we already have it working for text-box trim.
Note You need to log in before you can comment on or make changes to this bug.