240785 – input[type=search] preferred content width should not include decorations

RESOLVED FIXED 240785

input[type=search] preferred content width should not include decorations

https://bugs.webkit.org/show_bug.cgi?id=240785

Summary input[type=search] preferred content width should not include decorations

Tim Nguyen (:ntim)

Reported 2022-05-22 23:13:43 PDT Comment hidden (obsolete)

The searchfield still allocates space for the search clear button due to CSS in themeAdwaita.css. To fix this, styles added on ::-webkit-search-cancel-button from themeAdwaita.css need to be set by RenderThemeAdwaita.cpp instead in adjustSearchFieldCancelButtonStyle, notably width/height.

Attachments
Add attachment proposed patch, testcase, etc.

Tim Nguyen (:ntim)

Comment 1 2022-05-30 05:35:19 PDT

actually there's a better fix

Radar WebKit Bug Importer

Comment 2 2022-05-30 05:36:12 PDT

<rdar://problem/94113204>

Tim Nguyen (:ntim)

Comment 3 2022-05-30 07:14:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1161

EWS

Comment 4 2022-08-19 08:40:40 PDT

Committed 253595@main (5f2088ec9415): <https://commits.webkit.org/253595@main> Reviewed commits have been landed. Closing PR #1161 and removing active labels.

EWS

Comment 5 2022-08-20 11:22:23 PDT

Test gardening commit 253620@main (19719edc4942): <https://commits.webkit.org/253620@main> Reviewed commits have been landed. Closing PR #3505 and removing active labels.

Dawn Morningstar

Comment 6 2022-11-01 14:51:17 PDT

Re-opening for pull request https://github.com/apple/WebKit/pull/179

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Layout and Rendering

Assignee

Tim Nguyen (:ntim)

Reported

2022-05-22 23:13 PDT

Modified

2022-11-02 11:22 PDT History

CC List

5 users Show

URL

Keywords InRadar

Depends on

Blocks