RESOLVED FIXED Bug 24076
[Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=24076
Summary [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerat...
Jan Alonzo
Reported 2009-02-21 14:46:41 PST
We need to modify the path to point to libwebkit when detecting 3D transforms and accelerated compositing, just like how we do it when detecting SVG, WML, etc... The attached patch does this.
Attachments
modify path to point to libwebkit.so when detecting 3D transforms and accelerated compositing (1.23 KB, patch)
2009-02-21 14:47 PST, Jan Alonzo
no flags
refactor gtk lib detection and put it in one place (1.79 KB, patch)
2009-02-28 05:09 PST, Jan Alonzo
zecke: review+
Jan Alonzo
Comment 1 2009-02-21 14:47:51 PST
Created attachment 27856 [details] modify path to point to libwebkit.so when detecting 3D transforms and accelerated compositing
Holger Freyther
Comment 2 2009-02-26 06:50:54 PST
Comment on attachment 27856 [details] modify path to point to libwebkit.so when detecting 3D transforms and accelerated compositing Is there a way to remove the code duplication? E.g. changing the path before calling hasFoo..?
Jan Alonzo
Comment 3 2009-02-28 05:09:53 PST
Created attachment 28114 [details] refactor gtk lib detection and put it in one place Hi zecke. This patch does what you asked for. Thanks for the feedback.
Holger Freyther
Comment 4 2009-02-28 19:42:07 PST
Comment on attachment 28114 [details] refactor gtk lib detection and put it in one place Assuming the path is correct. Thanks for the cleanup.
Jan Alonzo
Comment 5 2009-02-28 22:22:06 PST
Landed in r42326. Thanks!
Note You need to log in before you can comment on or make changes to this bug.