Bug 240741 - WebAssembly: sync wasm.json files
Summary: WebAssembly: sync wasm.json files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-20 15:22 PDT by Asumu Takikawa
Modified: 2022-05-22 23:47 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2022-05-20 15:22:23 PDT
The two wasm.json files in the source tree that are supposed to be synced have drifted a bit:

```
$ diff Source/JavaScriptCore/wasm/wasm.json JSTests/wasm/wasm.json 
20c20
<         "rtt":       { "type": "varint7", "value":  -24, "b3type": "B3::Int64" },
---
>         "rtt":       { "type": "varint7", "value":  -24, "b3type": "B3::Void" },
189,190c189,190
<         "f32.min":             { "category": "arithmetic", "value": 150, "return": ["f32"],                          "parameter": ["f32", "f32"],                 "immediate": [], "b3op": "FMin" },
<         "f32.max":             { "category": "arithmetic", "value": 151, "return": ["f32"],                          "parameter": ["f32", "f32"],                 "immediate": [], "b3op": "FMax" },
---
>         "f32.min":             { "category": "arithmetic", "value": 150, "return": ["f32"],                          "parameter": ["f32", "f32"],                 "immediate": [], "b3op": "Select(Equal(@0, @1), BitOr(@0, @1), Select(LessThan(@0, @1), @0, Select(GreaterThan(@0, @1), @1, Add(@0, @1))))" },
>         "f32.max":             { "category": "arithmetic", "value": 151, "return": ["f32"],                          "parameter": ["f32", "f32"],                 "immediate": [], "b3op": "Select(Equal(@0, @1), BitAnd(@0, @1), Select(LessThan(@0, @1), @1, Select(GreaterThan(@0, @1), @0, Add(@0, @1))))" },
209,210c209,210
<         "f64.min":             { "category": "arithmetic", "value": 164, "return": ["f64"],                          "parameter": ["f64", "f64"],                 "immediate": [], "b3op": "FMin" },
<         "f64.max":             { "category": "arithmetic", "value": 165, "return": ["f64"],                          "parameter": ["f64", "f64"],                 "immediate": [], "b3op": "FMax" },
---
>         "f64.min":             { "category": "arithmetic", "value": 164, "return": ["f64"],                          "parameter": ["f64", "f64"],                 "immediate": [], "b3op": "Select(Equal(@0, @1), BitOr(@0, @1), Select(LessThan(@0, @1), @0, Select(GreaterThan(@0, @1), @1, Add(@0, @1))))" },
>         "f64.max":             { "category": "arithmetic", "value": 165, "return": ["f64"],                          "parameter": ["f64", "f64"],                 "immediate": [], "b3op": "Select(Equal(@0, @1), BitAnd(@0, @1), Select(LessThan(@0, @1), @1, Select(GreaterThan(@0, @1), @0, Add(@0, @1))))" },
```

I don't suspect there is a functional issue here as I don't think the tests care about "b3op" or "b3type", but they should probably be synced anyway.
Comment 1 Asumu Takikawa 2022-05-20 16:04:00 PDT
Pull request: https://github.com/WebKit/WebKit/pull/866
Comment 2 EWS 2022-05-22 23:46:37 PDT
Committed r294627 (250853@main): <https://commits.webkit.org/250853@main>

Reviewed commits have been landed. Closing PR #866 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-22 23:47:14 PDT
<rdar://problem/93741797>