Bug 240721 - RenderObject::containerForRepaint should be able to tell if a full repaint has already been scheduled.
Summary: RenderObject::containerForRepaint should be able to tell if a full repaint ha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 240728
  Show dependency treegraph
 
Reported: 2022-05-20 10:39 PDT by zalan
Modified: 2022-05-23 17:02 PDT (History)
12 users (show)

See Also:


Attachments
Patch (23.91 KB, patch)
2022-05-20 10:51 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (24.90 KB, patch)
2022-05-20 10:52 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (24.76 KB, patch)
2022-05-20 12:52 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (24.76 KB, patch)
2022-05-22 15:32 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-05-20 10:39:07 PDT
so that we don't issue redundant repaints
Comment 1 zalan 2022-05-20 10:51:21 PDT
Created attachment 459620 [details]
Patch
Comment 2 zalan 2022-05-20 10:52:12 PDT
Created attachment 459621 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-05-20 11:45:14 PDT
Comment on attachment 459621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459621&action=review

> Source/WebCore/rendering/RenderView.cpp:452
>      repaintUsingContainer(repaintContainer, computeRectForRepaint(layoutOverflowRect(), repaintContainer));

Can repaintUsingContainer take a RenderElement& after this change?
Comment 4 zalan 2022-05-20 12:52:41 PDT
Created attachment 459625 [details]
Patch
Comment 5 zalan 2022-05-20 14:19:03 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 459621 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459621&action=review
> 
> > Source/WebCore/rendering/RenderView.cpp:452
> >      repaintUsingContainer(repaintContainer, computeRectForRepaint(layoutOverflowRect(), repaintContainer));
> 
> Can repaintUsingContainer take a RenderElement& after this change?
Yeah, I've been considering that change for a while, but I don't think we are there yet. After https://bugs.webkit.org/attachment.cgi?id=459627&action=prettypatch, where both repaint and repaintRectangle start replacing null_ptr repaint container with the view(), I think it should be relatively easy to do.
Comment 6 zalan 2022-05-22 15:32:32 PDT
Created attachment 459651 [details]
Patch
Comment 7 EWS 2022-05-23 17:01:06 PDT
Committed r294699 (250898@main): <https://commits.webkit.org/250898@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459651 [details].
Comment 8 Radar WebKit Bug Importer 2022-05-23 17:02:15 PDT
<rdar://problem/93793768>