Bug 24072 - [Gtk] add options for 3D transforms and HTML5 channel messaging to the build
Summary: [Gtk] add options for 3D transforms and HTML5 channel messaging to the build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-02-21 00:46 PST by Jan Alonzo
Modified: 2009-02-24 01:22 PST (History)
1 user (show)

See Also:


Attachments
add channel messaging and 3D transforms support for autotools build (7.33 KB, patch)
2009-02-21 00:48 PST, Jan Alonzo
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2009-02-21 00:46:19 PST
build-webkit currently allows toggling of HTML5 channel messaging and 3D transforms. The following patch adds these options to configure.ac as well as allowing these to be turned on/off in build-webkit for autotools.

The patch also renames the web-workers option from --enable-workers to --enable-web-workers so configure doesn't warn about an unrecognize option '--enable-workers'.

Lastly, I took the opportunity to add '--gtk' in build-webkit's --help doc.
Comment 1 Jan Alonzo 2009-02-21 00:48:38 PST
Created attachment 27850 [details]
add channel messaging and 3D transforms support for autotools build
Comment 2 Alexey Proskuryakov 2009-02-23 13:45:26 PST
(In reply to comment #0)
> The patch also renames the web-workers option from --enable-workers to
> --enable-web-workers so configure doesn't warn about an unrecognize option
> '--enable-workers'.

I don't understand this comment. Why does configure warn about --enable-workers? This is how it was called from the start.
Comment 3 Jan Alonzo 2009-02-23 14:23:51 PST
(In reply to comment #2)
> (In reply to comment #0)
> > The patch also renames the web-workers option from --enable-workers to
> > --enable-web-workers so configure doesn't warn about an unrecognize option
> > '--enable-workers'.
> 
> I don't understand this comment. Why does configure warn about
> --enable-workers? This is how it was called from the start.
> 

Hi ap. The argname in configure.ac is web_workers, hence why I renamed the option to web-workers. I could just rename the arg to workers so --enable-workers will just work. Which one do you prefer? I'm happy either way.

Thanks!
Comment 4 Alexey Proskuryakov 2009-02-23 14:33:05 PST
Changing existing build-webkit switches will negatively affect people who have custom scripts wrapping it. I don't know if anyone depends on the current name of this particular option though.
Comment 5 Jan Alonzo 2009-02-23 15:11:20 PST
(In reply to comment #4)
> Changing existing build-webkit switches will negatively affect people who have
> custom scripts wrapping it. I don't know if anyone depends on the current name
> of this particular option though.

Hi ap. I've only changed the option that will be passed to autotools. The build-Webkit option stays the same.

Thanks.

Comment 6 Alexey Proskuryakov 2009-02-23 23:50:57 PST
Comment on attachment 27850 [details]
add channel messaging and 3D transforms support for autotools build

My mistake, sorry. r=me
Comment 7 Jan Alonzo 2009-02-24 01:22:54 PST
Landed in r41172. Thanks Alexey!