Bug 24072 – [Gtk] add options for 3D transforms and HTML5 channel messaging to the build

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jan Alonzo]

build-webkit currently allows toggling of HTML5 channel messaging and 3D transforms. The following patch adds these options to configure.ac as well as allowing these to be turned on/off in build-webkit for autotools.

The patch also renames the web-workers option from --enable-workers to --enable-web-workers so configure doesn't warn about an unrecognize option '--enable-workers'.

Lastly, I took the opportunity to add '--gtk' in build-webkit's --help doc.

[Jan Alonzo]

Created attachment 27850 [details]
add channel messaging and 3D transforms support for autotools build

[Alexey Proskuryakov]

(In reply to comment #0)
> The patch also renames the web-workers option from --enable-workers to
> --enable-web-workers so configure doesn't warn about an unrecognize option
> '--enable-workers'.

I don't understand this comment. Why does configure warn about --enable-workers? This is how it was called from the start.

[Jan Alonzo]

(In reply to comment #2)
> (In reply to comment #0)
> > The patch also renames the web-workers option from --enable-workers to
> > --enable-web-workers so configure doesn't warn about an unrecognize option
> > '--enable-workers'.
> 
> I don't understand this comment. Why does configure warn about
> --enable-workers? This is how it was called from the start.
> 

Hi ap. The argname in configure.ac is web_workers, hence why I renamed the option to web-workers. I could just rename the arg to workers so --enable-workers will just work. Which one do you prefer? I'm happy either way.

Thanks!

[Alexey Proskuryakov]

Changing existing build-webkit switches will negatively affect people who have custom scripts wrapping it. I don't know if anyone depends on the current name of this particular option though.

[Jan Alonzo]

(In reply to comment #4)
> Changing existing build-webkit switches will negatively affect people who have
> custom scripts wrapping it. I don't know if anyone depends on the current name
> of this particular option though.

Hi ap. I've only changed the option that will be passed to autotools. The build-Webkit option stays the same.

Thanks.

[Alexey Proskuryakov]

Comment on attachment 27850 [details]
add channel messaging and 3D transforms support for autotools build

My mistake, sorry. r=me

[Jan Alonzo]

Landed in r41172. Thanks Alexey!