RESOLVED FIXED 240689
prepare-commit-msg adds comments when called with --no-edit 
https://bugs.webkit.org/show_bug.cgi?id=240689
Summary prepare-commit-msg adds comments when called with --no-edit
Sam Sneddon [:gsnedders]
Reported 2022-05-19 15:30:41 PDT
If I run `git commit --amend --no-edit` with a commit whose message is "foo", I end up with: foo # Please populate the above commit message. Lines starting # with '#' will be ignored # On branch git-editor-colon # Changes to be committed: # (use "git restore --staged <file>..." to unstage) # modified: Tools/Scripts/hooks/prepare-commit-msg # # Changes not staged for commit: # (use "git add <file>..." to update what will be committed) # (use "git restore <file>..." to discard changes in working directory) # modified: Tools/Scripts/hooks/prepare-commit-msg # # Untracked files: # (use "git add <file>..." to include in what will be committed) # Source/InternalSettingsGenerated.idl #
Attachments
Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2022-05-19 16:47:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/810
EWS
Comment 2 2022-05-19 19:33:13 PDT
Committed r294524 (250779@main): <https://commits.webkit.org/250779@main> Reviewed commits have been landed. Closing PR #810 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-05-19 19:34:16 PDT
<rdar://problem/93624124>
Note You need to log in before you can comment on or make changes to this bug.