Bug 240675 - An update to a PR suggests a commit message that fails to copy the commit message from an earlier revision
Summary: An update to a PR suggests a commit message that fails to copy the commit mes...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-19 11:18 PDT by Simon Fraser (smfr)
Modified: 2022-05-26 11:19 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-05-19 11:18:51 PDT 
I've already created a PR from a local branch: https://github.com/WebKit/WebKit/pull/765
Now I want to update that PR, so make some local changes, stage them, and run `git-webkit pr --no-update`

This opens an editor that contains:

Need a short description (OOPS!).
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

No new tests (OOPS!).
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::canUseDescendantClippingLayer):

Shouldn't this take the title/bug from the earlier commit on this branch?
Comment 1 Jonathan Bedard 2022-05-19 11:25:01 PDT 
You're actually adding a new commit, not amending an existing one.

I think the point about forwarding the bug details stands, though.
Comment 2 Radar WebKit Bug Importer 2022-05-26 11:19:12 PDT 
<rdar://problem/93983615>