Bug 240610 - REGRESSION (r294160): Occasional infinite loops under updateLayersForInteractionRegions
Summary: REGRESSION (r294160): Occasional infinite loops under updateLayersForInteract...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-18 16:27 PDT by Tim Horton
Modified: 2022-05-18 21:10 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.83 KB, patch)
2022-05-18 16:30 PDT, Tim Horton
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-05-18 16:27:25 PDT
REGRESSION (r294160): Occasional infinite loops under updateLayersForInteractionRegions
Comment 1 Tim Horton 2022-05-18 16:30:33 PDT
Created attachment 459560 [details]
Patch
Comment 2 Tim Horton 2022-05-18 16:30:35 PDT
<rdar://problem/93507791>
Comment 3 Tim Horton 2022-05-18 16:32:04 PDT
I will figure out the changelog shenanigans.
Comment 4 Wenson Hsieh 2022-05-18 16:35:22 PDT
Comment on attachment 459560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459560&action=review

Seems reasonable to me!

> Source/WebCore/platform/graphics/IntRectHash.h:49
> +    static WebCore::IntRect emptyValue() { return { -2, -2, -2, -2 }; }

Out of curiosity, is there a reason why we opt for this value?

(CoreGraphics has a notion of `CGRectNull` that's something along the lines of { 0, 0, ∞, ∞ }, for instance)
Comment 5 Wenson Hsieh 2022-05-18 16:39:31 PDT
Comment on attachment 459560 [details]
Patch

(Chris, Tim and I discussed this on Slack and agreed to go with a separate hashtraits object that supports empty rects)
Comment 6 Tim Horton 2022-05-18 16:58:00 PDT
(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 459560 [details]
> Patch
> 
> (Chris, Tim and I discussed this on Slack and agreed to go with a separate
> hashtraits object that supports empty rects)

Rather, I am just going to change my code to not emit empty rects.
Comment 7 Tim Horton 2022-05-18 19:49:34 PDT
Pull request: https://github.com/WebKit/WebKit/pull/761
Comment 8 EWS 2022-05-18 21:10:38 PDT
Committed r294467 (250729@main): <https://commits.webkit.org/250729@main>

Reviewed commits have been landed. Closing PR #761 and removing active labels.