Bug 240610 – REGRESSION (r294160): Occasional infinite loops under updateLayersForInteractionRegions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

REGRESSION (r294160): Occasional infinite loops under updateLayersForInteractionRegions

[Tim Horton]

Created attachment 459560 [details]
Patch

[Tim Horton]

<rdar://problem/93507791>

[Tim Horton]

I will figure out the changelog shenanigans.

[Wenson Hsieh]

Comment on attachment 459560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459560&action=review

Seems reasonable to me!

> Source/WebCore/platform/graphics/IntRectHash.h:49
> +    static WebCore::IntRect emptyValue() { return { -2, -2, -2, -2 }; }

Out of curiosity, is there a reason why we opt for this value?

(CoreGraphics has a notion of `CGRectNull` that's something along the lines of { 0, 0, ∞, ∞ }, for instance)

[Wenson Hsieh]

Comment on attachment 459560 [details]
Patch

(Chris, Tim and I discussed this on Slack and agreed to go with a separate hashtraits object that supports empty rects)

[Tim Horton]

(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 459560 [details]
> Patch
> 
> (Chris, Tim and I discussed this on Slack and agreed to go with a separate
> hashtraits object that supports empty rects)

Rather, I am just going to change my code to not emit empty rects.

[Tim Horton]

Pull request: https://github.com/WebKit/WebKit/pull/761

[EWS]

Committed r294467 (250729@main): <https://commits.webkit.org/250729@main>

Reviewed commits have been landed. Closing PR #761 and removing active labels.