Bug 24060 - Fix up to match with the CanvasPixelArray reintroduction
Summary: Fix up to match with the CanvasPixelArray reintroduction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-20 08:15 PST by Dimitri Glazkov (Google)
Modified: 2009-02-21 20:24 PST (History)
0 users

See Also:


Attachments
Fix up to accommodate for CanvasPixelArray return, v1. (1.76 KB, patch)
2009-02-20 08:46 PST, Dimitri Glazkov (Google)
eric: review-
Details | Formatted Diff | Diff
Fix up to accommodate for CanvasPixelArray return, v2 (1.77 KB, patch)
2009-02-20 13:12 PST, Dimitri Glazkov (Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-02-20 08:15:33 PST
In http://trac.webkit.org/changeset/40089, CanvasPixelArray is back, which creates the need for this change.
Comment 1 Dimitri Glazkov (Google) 2009-02-20 08:46:44 PST
Created attachment 27831 [details]
Fix up to accommodate for CanvasPixelArray return, v1.

 WebCore/ChangeLog                                  |   11 +++++++++++
 WebCore/platform/graphics/skia/ImageBufferSkia.cpp |    4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)
Comment 2 Eric Seidel (no email) 2009-02-20 10:00:58 PST
Comment on attachment 27831 [details]
Fix up to accommodate for CanvasPixelArray return, v1.

source->data()->data()-data()

Wrong.
Comment 3 Dimitri Glazkov (Google) 2009-02-20 13:12:13 PST
Created attachment 27837 [details]
Fix up to accommodate for CanvasPixelArray return, v2

 WebCore/ChangeLog                                  |   11 +++++++++++
 WebCore/platform/graphics/skia/ImageBufferSkia.cpp |    4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)
Comment 4 Eric Seidel (no email) 2009-02-20 13:16:24 PST
Comment on attachment 27837 [details]
Fix up to accommodate for CanvasPixelArray return, v2

Right!
Comment 5 Dimitri Glazkov (Google) 2009-02-21 20:24:33 PST
Landed as http://trac.webkit.org/changeset/41119.