Bug 240577 - Remove unused memory capacity output value in calculateURLCacheSizes
Summary: Remove unused memory capacity output value in calculateURLCacheSizes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-18 06:50 PDT by Olivier Blin
Modified: 2022-05-19 20:48 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.20 KB, patch)
2022-05-18 06:53 PDT, Olivier Blin 		achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2022-05-18 06:50:27 PDT 
calculateURLCacheSizes() had a urlCacheMemoryCapacity output value since its creation in r203857, which was passed to platformSetURLCacheSize().

But the implementation has been removed for the soup platform in r205556 when switching to the WebKit network cache, and for the Cocoa platform in r232201 when dropping NSURLCache support.

urlCacheMemoryCapacity is now unused.
Comment 1 Olivier Blin 2022-05-18 06:53:07 PDT 
Created attachment 459539 [details]
Patch
Comment 2 Alex Christensen 2022-05-18 09:35:19 PDT 
Comment on attachment 459539 [details]
Patch

r=me
I think this needs a COMMIT_MESSAGE which is uploaded automatically with webkit-patch upload after you commit locally with git.
Comment 3 Olivier Blin 2022-05-19 01:23:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/771
Comment 4 EWS 2022-05-19 20:47:20 PDT 
Committed r294527 (250782@main): <https://commits.webkit.org/250782@main>

Reviewed commits have been landed. Closing PR #771 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2022-05-19 20:48:13 PDT 
<rdar://problem/93626827>