Bug 240573 - [EWS] links to wrong commit when closing pull request
Summary: [EWS] links to wrong commit when closing pull request
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-18 05:34 PDT by Michael Catanzaro
Modified: 2022-05-25 05:35 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-05-18 05:34:32 PDT 
In https://github.com/WebKit/WebKit/pull/700#issuecomment-1129482085 the EWS says:

Committed r294379 (250671@main): https://commits.webkit.org/250671@main

But that is a completely different commit than what it landed. What it actually landed was:

https://commits.webkit.org/250676@main

It might be related to the fact that EWS rebased this PR on top of three unrelated commits, although it's not clear how it wound up with the number 250671. It looks like everything landed fine in main, and only the comment in the pull request is wrong.
Comment 1 Michael Catanzaro 2022-05-18 05:38:45 PDT 
(In reply to Michael Catanzaro from comment #0)
> only the comment in the pull request is wrong.

Well the same wrong comment is on Bugzilla too: https://bugs.webkit.org/show_bug.cgi?id=240536#c2
Comment 2 Radar WebKit Bug Importer 2022-05-25 05:35:14 PDT 
<rdar://problem/93895857>