RESOLVED FIXED 240543
[Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script 
https://bugs.webkit.org/show_bug.cgi?id=240543
Summary [Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
Adrian Perez
Reported 2022-05-17 15:24:22 PDT
Traceback (most recent call last): File "/app/webkit/Tools/Scripts/check-for-invalid-symbols-in-version-script", line 33, in <module> if symbol not in data: TypeError: a bytes-like object is required, not 'str' --- As with other recent examples we need to decode the bytes objects returned by reading from the popen stream into strings (see the fix for “check-for-global-bss-symbols-in-webkitgtk-libs”, bug #237442, for an example of a similar fix)
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-05-17 15:31:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/699
EWS
Comment 2 2022-05-17 16:18:37 PDT
Committed r294358 (250663@main): <https://commits.webkit.org/250663@main> Reviewed commits have been landed. Closing PR #699 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-05-17 16:19:13 PDT
<rdar://problem/93460708>
Note You need to log in before you can comment on or make changes to this bug.