Bug 240530 - REGRESSION (r294272): TestWebKitAPI Failures after compile guard change
Summary: REGRESSION (r294272): TestWebKitAPI Failures after compile guard change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
: 240555 (view as bug list)
Depends on: 240469
Blocks:
  Show dependency tree / graph
 
Reported: 2022-05-17 11:10 PDT by Brent Fulgham
Modified: 2022-05-18 12:39 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-05-17 11:10:16 PDT 
A number of tests depend on ENABLE(NOTIFICATIONS), but aren't guarded so they are excluded on builds where that flag is disabled. This patch corrects that bug.
Comment 1 Brent Fulgham 2022-05-17 15:51:16 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/701
Comment 2 Brent Fulgham 2022-05-18 10:31:00 PDT 
*** Bug 240555 has been marked as a duplicate of this bug. ***
Comment 3 Brent Fulgham 2022-05-18 10:39:18 PDT 
<rdar://93468337>
Comment 4 EWS 2022-05-18 12:39:53 PDT 
Committed r294425 (250707@main): <https://commits.webkit.org/250707@main>

Reviewed commits have been landed. Closing PR #701 and removing active labels.