Bug 240492 - Use ASCIILiteral for JSC::HashTableValue::m_key
Summary: Use ASCIILiteral for JSC::HashTableValue::m_key
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-16 16:47 PDT by Chris Dumez
Modified: 2022-05-17 14:25 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-05-16 16:47:37 PDT
Use ASCIILiteral for JSC::HashTableValue::m_key since the key is always a string literal. This allows JSC::reifyStaticProperties() to call a more optimal Identifier::fromString(VM&, ASCIILiteral) overload.
Comment 1 Chris Dumez 2022-05-16 19:03:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/660
Comment 2 EWS 2022-05-17 14:24:54 PDT
Committed r294346 (250658@main): <https://commits.webkit.org/250658@main>

Reviewed commits have been landed. Closing PR #660 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-17 14:25:13 PDT
<rdar://problem/93452636>