Bug 240483 - Private relay should fail closed for third party loads if the main resource was loaded over private relay
Summary: Private relay should fail closed for third party loads if the main resource w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on: 240740
Blocks:
  Show dependency tree / graph
 
Reported: 2022-05-16 15:21 PDT by Alex Christensen
Modified: 2022-05-24 12:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.42 KB, patch)
2022-05-16 15:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (8.25 KB, patch)
2022-05-17 15:19 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
reverting patch (6.86 KB, patch)
2022-05-20 15:40 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (4.44 KB, patch)
2022-05-20 20:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-05-16 15:21:03 PDT 
Private relay should fail closed for third party loads if the main resource was loaded over private relay
Comment 1 Alex Christensen 2022-05-16 15:25:37 PDT 
Created attachment 459458 [details]
Patch
Comment 2 Alex Christensen 2022-05-16 15:25:41 PDT 
<rdar://problem/92697007>
Comment 3 Alex Christensen 2022-05-17 15:19:28 PDT 
Created attachment 459518 [details]
Patch
Comment 4 EWS 2022-05-17 17:56:41 PDT 
Committed r294371 (250670@main): <https://commits.webkit.org/250670@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459518 [details].
Comment 5 WebKit Commit Bot 2022-05-20 15:13:14 PDT 
Re-opened since this is blocked by bug 240740
Comment 6 Alex Christensen 2022-05-20 15:40:37 PDT 
Created attachment 459629 [details]
reverting patch
Comment 7 Alex Christensen 2022-05-20 20:23:12 PDT 
Created attachment 459635 [details]
Patch
Comment 8 Alex Christensen 2022-05-23 09:38:56 PDT 
I verified that, when opening several news sites, the patch from 5/17 had some differences between whether it calls _setPrivacyProxyFailClosedForUnreachableNonMainHosts on requests to the same hosts, which would cause different TCP connections to be made, which explains the performance regression.

I verified that the patch from 5/20 does not do this.
Comment 9 Chris Dumez 2022-05-23 09:41:39 PDT 
Comment on attachment 459635 [details]
Patch

r=me
Comment 10 EWS 2022-05-24 12:36:10 PDT 
Committed r294757 (250925@main): <https://commits.webkit.org/250925@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459635 [details].