RESOLVED FIXED 240478
check-webkit-style: validate enums declared with explicit type 
https://bugs.webkit.org/show_bug.cgi?id=240478
Summary check-webkit-style: validate enums declared with explicit type
Yury Semikhatsky
Reported 2022-05-16 14:09:52 PDT
check-webkit-style: validate enums declared with explicit type
Attachments
Patch (3.02 KB, patch)
2022-05-16 14:12 PDT, Yury Semikhatsky 		hi: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2022-05-16 14:12:10 PDT
Created attachment 459453 [details] Patch
Yury Semikhatsky
Comment 2 2022-05-16 14:12:58 PDT
This was discovered while looking at the style bot failures inhttps://bugs.webkit.org/show_bug.cgi?id=240326
Devin Rousso
Comment 3 2022-05-17 12:16:30 PDT
Comment on attachment 459453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review rs=mews > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396 > + '''enum class Type : uint8_t { FIRST, SECOND };''', i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`)
Yury Semikhatsky
Comment 4 2022-05-17 13:31:10 PDT
Pull request: https://github.com/WebKit/WebKit/pull/688
Yury Semikhatsky
Comment 5 2022-05-17 13:32:08 PDT
Comment on attachment 459453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review >> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396 >> + '''enum class Type : uint8_t { FIRST, SECOND };''', > > i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`) Done.
EWS
Comment 6 2022-05-17 15:01:38 PDT
Committed r294351 (250659@main): <https://commits.webkit.org/250659@main> Reviewed commits have been landed. Closing PR #688 and removing active labels.
Radar WebKit Bug Importer
Comment 7 2022-05-17 15:02:13 PDT
<rdar://problem/93455377>
Note You need to log in before you can comment on or make changes to this bug.