Bug 240478 - check-webkit-style: validate enums declared with explicit type
Summary: check-webkit-style: validate enums declared with explicit type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-16 14:09 PDT by Yury Semikhatsky
Modified: 2022-05-17 15:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.02 KB, patch)
2022-05-16 14:12 PDT, Yury Semikhatsky 		hi: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2022-05-16 14:09:52 PDT 
check-webkit-style: validate enums declared with explicit type
Comment 1 Yury Semikhatsky 2022-05-16 14:12:10 PDT 
Created attachment 459453 [details]
Patch
Comment 2 Yury Semikhatsky 2022-05-16 14:12:58 PDT 
This was discovered while looking at the style bot failures inhttps://bugs.webkit.org/show_bug.cgi?id=240326
Comment 3 Devin Rousso 2022-05-17 12:16:30 PDT 
Comment on attachment 459453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review

rs=mews

> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396
> +            '''enum class Type : uint8_t { FIRST, SECOND };''',

i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`)
Comment 4 Yury Semikhatsky 2022-05-17 13:31:10 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/688
Comment 5 Yury Semikhatsky 2022-05-17 13:32:08 PDT 
Comment on attachment 459453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review

>> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396
>> +            '''enum class Type : uint8_t { FIRST, SECOND };''',
> 
> i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`)

Done.
Comment 6 EWS 2022-05-17 15:01:38 PDT 
Committed r294351 (250659@main): <https://commits.webkit.org/250659@main>

Reviewed commits have been landed. Closing PR #688 and removing active labels.
Comment 7 Radar WebKit Bug Importer 2022-05-17 15:02:13 PDT 
<rdar://problem/93455377>