Bug 240463 - RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range
Summary: RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 240348 240464 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-05-16 10:17 PDT by Karl Rackler
Modified: 2022-05-23 06:38 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Rackler 2022-05-16 10:17:49 PDT
Description:
imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html

The first failure that I saw on the dashboard was 5/6/2022 at r293885, and the dashboard shows passing on r293882.  Between r293883 and r293885 probably introduced the consistent failure. 

REPRODUCTION STEPS
I can reproduce this on r293885, but repro against all earlier commits are also failures which is different from the dashboard history.

Command: 
run-webkit-tests --root 293885 --ios-simulator --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 --no-retry imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html

Result:  
Regressions: Unexpected text-only failures (1)
  imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Failure ]

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2FRTCRtpSender-replaceTrack.https.html&platform=ios&limit=50000

Diff:
--- /Volumes/Data/worker/Apple-iOS-15-Simulator-Debug-WK2-Tests/build/layout-test-results/imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https-expected.txt
+++ /Volumes/Data/worker/Apple-iOS-15-Simulator-Debug-WK2-Tests/build/layout-test-results/imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https-actual.txt
@@ -1,3 +1,5 @@
+
+Harness Error (TIMEOUT), message = null
 
 PASS Calling replaceTrack on closed connection should reject with InvalidStateError
 PASS Calling replaceTrack with track of different kind should reject with TypeError
@@ -8,5 +10,5 @@
 PASS Calling replaceTrack(null) on sender set to session description should resolve with sender.track set to null
 PASS Calling replaceTrack on sender with stopped track and and set to session description should resolve with sender.track set to given track
 PASS Calling replaceTrack on sender with similar track and and set to session description should resolve with sender.track set to new track
-PASS ReplaceTrack transmits the new track not the old track
+TIMEOUT ReplaceTrack transmits the new track not the old track Test timed out

stderr:
Failed to load 'about:blank', terminating process and trying again.
com.apple.WebKit.WebContent.Development terminated (pid 98337) for reason: requested by client
Failed to load 'about:blank' again after termination.
com.apple.WebKit.WebContent.Development terminated (pid 99211) for reason: requested by client
Comment 1 Radar WebKit Bug Importer 2022-05-16 10:18:08 PDT
<rdar://problem/93354226>
Comment 2 Karl Rackler 2022-05-16 10:23:40 PDT
I have marked this test as a consistent failure while this issue is investigated.
Comment 3 Karl Rackler 2022-05-16 10:28:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/638
Comment 4 EWS 2022-05-16 10:31:10 PDT
Test gardening commit r294239 (250597@main): <https://commits.webkit.org/250597@main>

Reviewed commits have been landed. Closing PR #638 and removing active labels.
Comment 5 Ryan Haddad 2022-05-16 14:55:08 PDT
The test history does indeed suggest that this started with r293885 / 250343@main, and that is the only WebRTC related commit in the range.
Comment 6 Alexey Proskuryakov 2022-05-16 17:13:34 PDT
*** Bug 240464 has been marked as a duplicate of this bug. ***
Comment 7 youenn fablet 2022-05-23 04:12:19 PDT
*** Bug 240348 has been marked as a duplicate of this bug. ***
Comment 8 youenn fablet 2022-05-23 04:17:36 PDT
https://github.com/WebKit/WebKit/pull/909
Comment 9 EWS 2022-05-23 06:38:56 PDT
Committed r294637 (250861@main): <https://commits.webkit.org/250861@main>

Reviewed commits have been landed. Closing PR #909 and removing active labels.