Commit-Queue should only allow commit messages and forbid ChangeLog modification.
<rdar://problem/93351783>
Created attachment 459431 [details] Patch
Unable to find any modified ChangeLog in Attachment 459431 [details]
Created attachment 459449 [details] Patch
Comment on attachment 459449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459449&action=review > Tools/CISupport/ews-build/config.json:338 > + "workernames": ["webkit-cq-01", "webkit-cq-02", "webkit-cq-03", "ews151"] seems like this is for debugging > Tools/CISupport/ews-build/factories.py:309 > + self.addStep(ShowCommitMessage()) why do we need ShowCommitMessage? > Tools/CISupport/ews-build/steps.py:882 > + if not patch: Should remove this fallback. If the patch is not found, there is something seriously wrong, we shouldn't automatically try to fix that. Better to explicitly fail. > Tools/CISupport/ews-build/steps.py:893 > + def hideStepIf(self, results, step): Nit: should move this next to showStepIf > Tools/CISupport/ews-build/steps.py:898 > + return {'step': "Skipping creating commitsince patch_id isn't provided"} Better not to have custom skipped message, it wouldn't be displayed anyways based on hideStepIf > Tools/CISupport/ews-build/steps.py:900 > + return {'step': 'git am failed to apply patch to trunk'} Nit: "git am" => "git", am is technial details, better to tell user high-level and easy to understand thing.
rs=me with these changes and unit-test fixed.
Created attachment 459495 [details] Patch
Unable to find any modified ChangeLog in Attachment 459495 [details]
https://ews-build.webkit-uat.org/#/builders/26/builds/2095 shows that we are adding the author to the commit message correctly
Created attachment 459496 [details] Patch
rs=me
Created attachment 459500 [details] [fast-cq] Patch
Created attachment 459503 [details] [fast-cq] Patch
Created attachment 459505 [details] [fast-cq] Patch
Committed r294327 (250647@main): <https://commits.webkit.org/250647@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459505 [details].
Reopening to attach new patch.
Created attachment 459508 [details] Patch
Committed r294336 (250655@main): <https://commits.webkit.org/250655@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459508 [details].
Re-opening for pull request https://github.com/WebKit/WebKit/pull/732
Pull request: https://github.com/apple/WebKit/pull/7
Committed r294403 (250697@main): <https://commits.webkit.org/250697@main> Reviewed commits have been landed. Closing PR #732 and removing active labels.