Bug 240459 – [WebAuthn] Set displayName in AuthenticatorAssertionResponse for platform authenticator

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[[e-mail]]

This prevents the display name from being passed to the UI.

[Radar WebKit Bug Importer]

<rdar://problem/93350479>

[[e-mail]]

Created attachment 459440 [details]
Patch

[[e-mail]]

Created attachment 459442 [details]
Patch

[Brent Fulgham]

Comment on attachment 459442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459442&action=review

r=me

> Source/WebKit/ChangeLog:3
> +        [WebAuthn] Set displayName in AuthenticatorAssertionResponse for platform authenticator

Question: I'm not sure how setting the displayName here "prevents the display name from being passed to the UI". Did the bug mean to say "prevents the user name from being passed to the UI?"

[Brent Fulgham]

The windows test failure does not seem to be related to this Cocoa and WebAuth-specific change.

[[e-mail]]

(In reply to Brent Fulgham from comment #4)
> 
> > Source/WebKit/ChangeLog:3
> > +        [WebAuthn] Set displayName in AuthenticatorAssertionResponse for platform authenticator
> 
> Question: I'm not sure how setting the displayName here "prevents the
> display name from being passed to the UI". Did the bug mean to say "prevents
> the user name from being passed to the UI?"

Thank you for the review.

I meant to say: Not setting the displayName in AuthenticatorAssertionResponse for platform credentials is a bug. This bug prevents the UI code from seeing the displayName for a credential, if available. The patch fixes this.

[[e-mail]]

Pull request: https://github.com/WebKit/WebKit/pull/682

[EWS]

Committed r294331 (250651@main): <https://commits.webkit.org/250651@main>

Reviewed commits have been landed. Closing PR #682 and removing active labels.