Bug 240453 - [WPE] Use new libwpe API to synchronise display refreshes fully to the screen refresh rate
Summary: [WPE] Use new libwpe API to synchronise display refreshes fully to the screen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-16 05:28 PDT by Chris Lord
Modified: 2022-07-11 08:56 PDT (History)
14 users (show)

See Also:


Attachments
Patch (14.36 KB, patch)
2022-05-16 07:46 PDT, Chris Lord
no flags Details | Formatted Diff | Diff
Patch (14.36 KB, patch)
2022-05-17 01:27 PDT, Chris Lord
no flags Details | Formatted Diff | Diff
Patch (14.44 KB, patch)
2022-05-17 02:29 PDT, Chris Lord
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2022-05-16 05:28:55 PDT
In ThreadedDisplayRefreshMonitor there's a FIXME to use the correct frame-rate for the DisplayUpdate object used for DisplayRefreshMonitor::displayDidRefresh - https://github.com/WebPlatformForEmbedded/libwpe/pull/104 adds API in libwpe to query/track the current display refresh that we can use for this.
Comment 1 Chris Lord 2022-05-16 07:46:44 PDT
Created attachment 459424 [details]
Patch
Comment 2 Adrian Perez 2022-05-16 14:32:26 PDT
In bug #240470 there is a patch to add a newer version of libwpe
to the Flatpak SDK which includes the needed API. Once that lands
and an update to the SDK is pushed, the EWS builds will notice and
build the code guarded with WPE_CHECK_VERSION()
Comment 3 Adrian Perez 2022-05-16 14:35:33 PDT
Comment on attachment 459424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459424&action=review

> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:124
> +#if WPE_CHECK_VERSION(1, 13, 0)

You'll want to change this to check for 1.13.2 before landing, which is the
version adding the new API: https://wpewebkit.org/release/libwpe-1.13.2.html

:)
Comment 4 Chris Lord 2022-05-17 01:27:28 PDT
Created attachment 459489 [details]
Patch
Comment 5 Chris Lord 2022-05-17 02:29:20 PDT
Created attachment 459492 [details]
Patch
Comment 6 EWS 2022-05-17 06:23:59 PDT
Committed r294322 (250642@main): <https://commits.webkit.org/250642@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459492 [details].