Bug 240452 – ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Kimmo Kinnunen]

ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone

[Kimmo Kinnunen]

Created attachment 459417 [details]
Patch

[EWS]

Committed r294317 (250637@main): <https://commits.webkit.org/250637@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459417 [details].

[Radar WebKit Bug Importer]

<rdar://problem/93412550>

[Karl Rackler]

*** Bug 240495 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Re-opened since this is blocked by bug 240613

[Dawn Morningstar]

Reverted here https://bugs.webkit.org/show_bug.cgi?id=240613 because this patch caused numerous layout-test failures/timeouts and two api test failures: https://bugs.webkit.org/show_bug.cgi?id=240551

[Robert Jenner]

Reverted r294317 for reason:

Broke multiple layout-tests, and 2 api-tests.

Committed r294452 (250720@trunk): <https://commits.webkit.org/250720@trunk>

[Robert Jenner]

The tests that broke this this were the following:

Layout-Tests:
editing/input/cocoa/autocorrect-off.html 
editing/input/cocoa/autocorrect-on.html 
editing/undo-manager/undo-manager-item-labels.html 
fast/forms/ios/autocapitalize-words.html
fast/forms/ios/form-control-refresh/select/select-multiple-picker.html
fast/forms/ios/inputmode-none.html
fast/forms/ios/no-scrolling-when-moving-focus-between-adjacent-fields.html
fast/forms/validation-messages.html
fast/forms/datalist/datalist.html
fast/forms/ios/inputmode-removing-none.html
fast/events/ios/do-not-show-keyboard-when-focusing-after-blur.html 
fast/events/ios/keyup.html 
fast/events/ios/unscalable-viewport-clicks-on-doubletap.html 
fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html 
http/wpt/webauthn/public-key-credential-unfocused-document.https.html 
mathml/fractions-invalid.html

API-Tests:
TestWebKitAPI.DragAndDropTests.CanDragImageWhenNotFirstResponder 
TestWebKitAPI.DragAndDropTests.InjectedBundleImageElementData

[Kimmo Kinnunen]

Pull request: https://github.com/WebKit/WebKit/pull/10515

[EWS]

Committed 260734@main (0072dcd9a13b): <https://commits.webkit.org/260734@main>

Reviewed commits have been landed. Closing PR #10515 and removing active labels.