Bug 240452 - ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone
Summary: ImageBufferIOSurfaceBackend context setup and teardown functions are redundan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
: 240495 (view as bug list)
Depends on: 240613
Blocks: 240417 240495
  Show dependency treegraph
 
Reported: 2022-05-16 05:26 PDT by Kimmo Kinnunen
Modified: 2023-02-23 01:26 PST (History)
8 users (show)

See Also:


Attachments
Patch (13.55 KB, patch)
2022-05-16 05:40 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-05-16 05:26:12 PDT
ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone
Comment 1 Kimmo Kinnunen 2022-05-16 05:40:24 PDT
Created attachment 459417 [details]
Patch
Comment 2 EWS 2022-05-17 02:48:43 PDT
Committed r294317 (250637@main): <https://commits.webkit.org/250637@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459417 [details].
Comment 3 Radar WebKit Bug Importer 2022-05-17 02:49:13 PDT
<rdar://problem/93412550>
Comment 4 Karl Rackler 2022-05-17 17:08:21 PDT
*** Bug 240495 has been marked as a duplicate of this bug. ***
Comment 5 WebKit Commit Bot 2022-05-18 17:01:51 PDT
Re-opened since this is blocked by bug 240613
Comment 6 Dawn Morningstar 2022-05-18 17:07:42 PDT
Reverted here https://bugs.webkit.org/show_bug.cgi?id=240613 because this patch caused numerous layout-test failures/timeouts and two api test failures: https://bugs.webkit.org/show_bug.cgi?id=240551
Comment 7 Robert Jenner 2022-05-18 17:42:37 PDT
Reverted r294317 for reason:

Broke multiple layout-tests, and 2 api-tests.

Committed r294452 (250720@trunk): <https://commits.webkit.org/250720@trunk>
Comment 8 Robert Jenner 2022-05-19 12:49:59 PDT
The tests that broke this this were the following:

Layout-Tests:
editing/input/cocoa/autocorrect-off.html 
editing/input/cocoa/autocorrect-on.html 
editing/undo-manager/undo-manager-item-labels.html 
fast/forms/ios/autocapitalize-words.html
fast/forms/ios/form-control-refresh/select/select-multiple-picker.html
fast/forms/ios/inputmode-none.html
fast/forms/ios/no-scrolling-when-moving-focus-between-adjacent-fields.html
fast/forms/validation-messages.html
fast/forms/datalist/datalist.html
fast/forms/ios/inputmode-removing-none.html
fast/events/ios/do-not-show-keyboard-when-focusing-after-blur.html 
fast/events/ios/keyup.html 
fast/events/ios/unscalable-viewport-clicks-on-doubletap.html 
fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html 
http/wpt/webauthn/public-key-credential-unfocused-document.https.html 
mathml/fractions-invalid.html

API-Tests:
TestWebKitAPI.DragAndDropTests.CanDragImageWhenNotFirstResponder 
TestWebKitAPI.DragAndDropTests.InjectedBundleImageElementData
Comment 9 Kimmo Kinnunen 2023-02-22 07:07:21 PST
Pull request: https://github.com/WebKit/WebKit/pull/10515
Comment 10 EWS 2023-02-23 01:26:26 PST
Committed 260734@main (0072dcd9a13b): <https://commits.webkit.org/260734@main>

Reviewed commits have been landed. Closing PR #10515 and removing active labels.