Bug 240445 - [GitHub] Why merged PRs have no commits/files changed information?
Summary: [GitHub] Why merged PRs have no commits/files changed information?
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-15 23:48 PDT by Manuel Rego Casasnovas
Modified: 2022-05-18 14:11 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2022-05-15 23:48:27 PDT 
When a PR gets merged it looks like it lost all the information regarding the commit and the changes made by that PR.

I believe it'd be useful to still see the changes there, like in a regular GitHub project.

Also I believe we are going to be losing context and information compared to the bugzilla workflow. In a complex patch that might have several review iterations and that might change the design or whatever, you'll have no way to see previous versions of the patch, or understand the review comments as you won't have the whole context anymore.
Comment 1 Alexey Proskuryakov 2022-05-16 09:01:35 PDT 
This is not intentional, and will stop happening once GitHub becomes the source of truth. I couldn't find an existing bug for this though.
Comment 2 Manuel Rego Casasnovas 2022-05-17 23:55:57 PDT 
(In reply to Alexey Proskuryakov from comment #1)
> This is not intentional, and will stop happening once GitHub becomes the
> source of truth. I couldn't find an existing bug for this though.

Good to know, I guess there's nothing to do until the GitHub transition is complete.

Feel free to close this or keep it open for tracking purpose, as you prefer.
Comment 3 Radar WebKit Bug Importer 2022-05-18 13:09:34 PDT 
<rdar://problem/93522063>