Bug 240442 - [LFC][FFC] Add support for logical ordering
Summary: [LFC][FFC] Add support for logical ordering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-15 21:44 PDT by zalan
Modified: 2022-05-16 10:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.16 KB, patch)
2022-05-15 21:48 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (4.16 KB, patch)
2022-05-16 06:09 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (3.72 KB, patch)
2022-05-16 09:36 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.72 KB, patch)
2022-05-16 09:53 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-05-15 21:44:21 PDT
order property
Comment 1 zalan 2022-05-15 21:48:08 PDT
Created attachment 459389 [details]
Patch
Comment 2 zalan 2022-05-16 06:09:31 PDT
Created attachment 459419 [details]
Patch
Comment 3 zalan 2022-05-16 09:36:18 PDT
Created attachment 459429 [details]
Patch
Comment 4 Antti Koivisto 2022-05-16 09:46:50 PDT
Comment on attachment 459429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459429&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:170
> +        std::sort(logicalFlexItemList.begin(), logicalFlexItemList.end(), [&] (auto& a, auto& b) {

Probably std::stable_sort? Otherwise identical items get ordered randomly.
Comment 5 zalan 2022-05-16 09:53:12 PDT
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 459429 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459429&action=review
> 
> > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:170
> > +        std::sort(logicalFlexItemList.begin(), logicalFlexItemList.end(), [&] (auto& a, auto& b) {
> 
> Probably std::stable_sort? Otherwise identical items get ordered randomly.
good point!
Comment 6 zalan 2022-05-16 09:53:27 PDT
Created attachment 459432 [details]
Patch
Comment 7 EWS 2022-05-16 10:36:51 PDT
Committed r294240 (250598@main): <https://commits.webkit.org/250598@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459432 [details].
Comment 8 Radar WebKit Bug Importer 2022-05-16 10:37:23 PDT
<rdar://problem/93355697>