Bug 24042 - MediaPlayer should cache plug-in proxy
Summary: MediaPlayer should cache plug-in proxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-19 14:05 PST by Eric Carlson
Modified: 2009-02-20 13:13 PST (History)
0 users

See Also:


Attachments
proposed patch (3.53 KB, patch)
2009-02-19 17:05 PST, Eric Carlson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2009-02-19 14:05:56 PST
The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that HTMLMediaElement::finishParsingChildren is always called before the plug-in gets instantiated and calls HTMLMediaElement::setMediaPlayerProxy. This is not true on all platforms because of threading latency, so MediaPlayer.cpp should cache the plug-in proxy so it can pass it to the media engine at a later time.
Comment 1 Eric Carlson 2009-02-19 17:05:42 PST
Created attachment 27817 [details]
proposed patch
Comment 2 Simon Fraser (smfr) 2009-02-20 12:05:10 PST
Comment on attachment 27817 [details]
proposed patch


> Index: WebCore/platform/graphics/MediaPlayer.cpp
> ===================================================================

> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +    virtual void setPoster(const String&) { }

setPoster(const String& /*url*/) would be slightly clearer.


> Index: WebCore/platform/graphics/MediaPlayer.h
> ===================================================================
> --- WebCore/platform/graphics/MediaPlayer.h	(revision 41083)
> +++ WebCore/platform/graphics/MediaPlayer.h	(working copy)
> @@ -149,6 +149,9 @@ private:
>      bool m_visible;
>      float m_rate;
>      float m_volume;
> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +    WebMediaPlayerProxy* m_playerProxy;
> +#endif

Maybe add a comment to say that m_playerProxy is not owned and where
it comes from?
Comment 3 Eric Carlson 2009-02-20 13:13:58 PST
Committed revision 41118.