RESOLVED WORKSFORME 240419
REGRESSION(r294161): Broke PrettyPatch when running layout tests 
https://bugs.webkit.org/show_bug.cgi?id=240419
Summary REGRESSION(r294161): Broke PrettyPatch when running layout tests
Philippe Normand
Reported 2022-05-14 05:17:10 PDT
run-webkit-tests --gtk --no-show-results media/encrypted-media/encrypted-media-constants.html Failed to run "('ruby', '-I', '/app/webkit/Websites/bugs.webkit.org/PrettyPatch', '/app/webkit/Websites/bugs.webkit.org/PrettyPatch/prettify.rb', '/app/webkit/WebKitBuild/Release/layout-test-results/media/encrypted-media/encrypted-media-constants-diff.txt')" exit_code: 1 Last 500 characters of output: b"Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `new'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `block in parse'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `collect'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `parse'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:21:in `prettify'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/prettify.rb:30:in `<main>'\n" full error output: b"/app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:642:in `initialize': undefined method `chomp' for nil:NilClass (NoMethodError)\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `new'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `block in parse'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `collect'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:844:in `parse'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:21:in `prettify'\n\tfrom /app/webkit/Websites/bugs.webkit.org/PrettyPatch/prettify.rb:30:in `<main>'\n"
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-05-21 05:18:13 PDT
<rdar://problem/93703477>
Jonathan Bedard
Comment 2 2023-05-02 09:02:02 PDT
I've tried to reproduce this, but can't. If this is still a problem, could we get the diff.txt that's causing it attached to this bug?
Note You need to log in before you can comment on or make changes to this bug.