Bug 240408 - [Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK
Summary: [Xcode] Prevent STP and other self-contained builds from overwriting content ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-13 18:21 PDT by Elliott Williams
Modified: 2022-06-02 11:30 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-05-13 18:21:52 PDT 
In STP and downlevels, static library content is written to /usr/local. This is confusing and potentially harmful, as it merges on top of content from the system's WebKit. We only need this content at build-time, which is why it's fine that it isn't bundled with `Safari Technology Preview.app`, but we should find a new location for it.
Comment 1 Elliott Williams 2022-05-13 18:22:40 PDT 
rdar://93068926
Comment 2 Elliott Williams 2022-05-13 18:32:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/624
Comment 3 EWS 2022-05-19 11:33:30 PDT 
Committed r294496 (250755@main): <https://commits.webkit.org/250755@main>

Reviewed commits have been landed. Closing PR #624 and removing active labels.
Comment 4 Elliott Williams 2022-05-24 14:54:40 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/987
Comment 5 EWS 2022-05-31 16:43:04 PDT 
Committed r295073 (251168@main): <https://commits.webkit.org/251168@main>

Reviewed commits have been landed. Closing PR #987 and removing active labels.
Comment 6 Elliott Williams 2022-06-01 16:58:15 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/1227
Comment 7 EWS 2022-06-02 11:30:33 PDT 
Committed r295134 (251225@main): <https://commits.webkit.org/251225@main>

Reviewed commits have been landed. Closing PR #1227 and removing active labels.