Bug 240404 – ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS

[Tim Horton]

Created attachment 459329 [details]
Patch

[Tim Horton]

<rdar://problem/93070349>

[Tim Horton]

Created attachment 459333 [details]
Patch

[Chris Dumez]

Comment on attachment 459333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459333&action=review

r=me

> Source/WTF/wtf/cocoa/FileSystemCocoa.mm:241
> +    static NeverDestroyed<RetainPtr<NSString>> path = adoptNS([^{

Why use adoptNS() + copy? Can we just assign the NSString* to the RetainPtr<> right away?

[Tim Horton]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 459333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459333&action=review
> 
> r=me
> 
> > Source/WTF/wtf/cocoa/FileSystemCocoa.mm:241
> > +    static NeverDestroyed<RetainPtr<NSString>> path = adoptNS([^{
> 
> Why use adoptNS() + copy? Can we just assign the NSString* to the
> RetainPtr<> right away?

I ... did not look at the code I was moving. That is weird, I agree!!

[Tim Horton]

Created attachment 459335 [details]
Patch

[Tim Horton]

Created attachment 459345 [details]
Patch

[EWS]

Committed r294188 (250554@main): <https://commits.webkit.org/250554@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459345 [details].