RESOLVED FIXED 24040
It should be possible to refresh items in the inspector's databases panel
https://bugs.webkit.org/show_bug.cgi?id=24040
Summary It should be possible to refresh items in the inspector's databases panel
Yael
Reported 2009-02-19 13:01:54 PST
Refreshing local storage, session storage and databases automatically could impact performance. People should have a way to refresh them manually.
Attachments
Add refresh button to Databases panel (3.62 KB, patch)
2009-02-19 13:06 PST, Yael
timothy: review-
Move the refresh button to the views (7.50 KB, patch)
2009-02-26 10:01 PST, Yael
timothy: review-
Addressing comment #4 (6.71 KB, patch)
2009-02-26 16:34 PST, Yael
timothy: review+
Yael
Comment 1 2009-02-19 13:06:46 PST
Created attachment 27809 [details] Add refresh button to Databases panel
Timothy Hatcher
Comment 2 2009-02-25 20:20:14 PST
Comment on attachment 27809 [details] Add refresh button to Databases panel The refresh button should be under the view side, like I mentioned for the delete button.
Yael
Comment 3 2009-02-26 10:01:42 PST
Created attachment 28020 [details] Move the refresh button to the views
Timothy Hatcher
Comment 4 2009-02-26 10:47:54 PST
Comment on attachment 28020 [details] Move the refresh button to the views > + this.refreshButton.removeStyleClass("hidden"); > + this.refreshButton.addStyleClass("hidden"); Why do you need to show/hide the button? Isn't this done by showing/hiding the whole storageViewStatusBarItemsContainer now? > + this.show(); It would be nice to have a refresh() function, calling show() again might do more than we want in the future.
Yael
Comment 5 2009-02-26 16:34:31 PST
Created attachment 28052 [details] Addressing comment #4 Removed the addStyleClass/removeStyleClass, is really is not needed. Instead of calling show(), calling update() which is a local function.
Yael
Comment 6 2009-02-26 17:16:35 PST
Thank you for the review. Now I need help committing this patch :-)
Timothy Hatcher
Comment 7 2009-02-27 10:56:23 PST
Landed in r41289.
Note You need to log in before you can comment on or make changes to this bug.