Bug 240362 - Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Summary: Use _adoptEffectiveConfiguration instead of a separate NSURLSession without c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-12 16:12 PDT by Alex Christensen
Modified: 2022-05-26 20:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.88 KB, patch)
2022-05-12 16:14 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (13.95 KB, patch)
2022-05-13 10:13 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.49 KB, patch)
2022-05-17 13:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.53 KB, patch)
2022-05-17 14:47 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (16.04 KB, patch)
2022-05-26 17:41 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-05-12 16:12:52 PDT 
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Comment 1 Alex Christensen 2022-05-12 16:14:34 PDT 
Created attachment 459256 [details]
Patch
Comment 2 Alex Christensen 2022-05-13 10:13:37 PDT 
Created attachment 459309 [details]
Patch
Comment 3 Alex Christensen 2022-05-16 09:30:48 PDT 
Perf testers say this is a 0.57% performance improvement.
Comment 4 Chris Dumez 2022-05-16 09:32:10 PDT 
Comment on attachment 459309 [details]
Patch

r=me
Comment 5 EWS 2022-05-16 09:50:36 PDT 
Committed r294238 (250596@main): <https://commits.webkit.org/250596@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459309 [details].
Comment 6 Radar WebKit Bug Importer 2022-05-16 09:51:13 PDT 
<rdar://problem/93352198>
Comment 7 Ryan Haddad 2022-05-16 14:37:09 PDT 
Reverted r294238 for reason:

Breaks internal builds

Committed r294261 (250609@trunk): <https://commits.webkit.org/250609@trunk>
Comment 8 Alex Christensen 2022-05-17 13:55:09 PDT 
Created attachment 459513 [details]
Patch
Comment 9 Alex Christensen 2022-05-17 14:47:20 PDT 
Created attachment 459516 [details]
Patch
Comment 10 Alex Christensen 2022-05-26 17:41:05 PDT 
Created attachment 459800 [details]
Patch
Comment 11 EWS 2022-05-26 20:51:12 PDT 
Committed r294927 (251038@main): <https://commits.webkit.org/251038@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459800 [details].