Bug 24036 - Keyboard events need disambiguation on the Linux platform too.
Summary: Keyboard events need disambiguation on the Linux platform too.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Enhancement
Assignee: Avi Drissman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-19 11:51 PST by Avi Drissman
Modified: 2009-02-20 07:34 PST (History)
0 users

See Also:


Attachments
Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac. (1.87 KB, patch)
2009-02-19 11:51 PST, Avi Drissman
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Avi Drissman 2009-02-19 11:51:07 PST
Linux (in all its flavors) needs the same disambiguation of events as the Mac does (see plat/gtk/KeyEventGtk.cpp, plat/qt/PlatformKeyboardEventQt.cpp, and plat/wx/KeyboardEventWc.cpp).
Comment 1 Avi Drissman 2009-02-19 11:51:59 PST
Created attachment 27805 [details]
Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac.
Comment 2 Avi Drissman 2009-02-19 11:52:27 PST
See http://codereview.chromium.org/21514 .
Comment 3 Eric Seidel (no email) 2009-02-19 14:27:33 PST
Comment on attachment 27805 [details]
Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac.

Looks fine to me.
Comment 4 Darin Fisher (:fishd, Google) 2009-02-20 07:34:58 PST
Landed as http://trac.webkit.org/changeset/41106