Bug 240347 - [WPE][GTK] Drop libnotify
Summary: [WPE][GTK] Drop libnotify
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-12 08:46 PDT by Michael Catanzaro
Modified: 2022-08-06 07:51 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2022-05-12 08:46:11 PDT 
Currently WPE has no support for desktop notifications.

GTK supports desktop notifications via libnotify, but this library has been deprecated for a very long time. We should switch to GNotification. This will finally support WPE, too.
Comment 1 Michael Catanzaro 2022-05-12 09:54:56 PDT 
(In reply to Michael Catanzaro from comment #0)
> We should switch to GNotification.

So I tried this today, but turns out the API is very awkward to use. Patrick suggests using the notifications portal D-Bus API directly. It's probably a smarter approach.
Comment 2 Carlos Garcia Campos 2022-08-05 04:31:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3040
Comment 3 EWS 2022-08-06 07:51:33 PDT 
Committed 253179@main (95858e6cc2e3): <https://commits.webkit.org/253179@main>

Reviewed commits have been landed. Closing PR #3040 and removing active labels.