Bug 240320 - Quirk flightaware.com to use old serialisation for number
Summary: Quirk flightaware.com to use old serialisation for number
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-11 16:02 PDT by Matt Woodrow
Modified: 2022-05-12 18:50 PDT (History)
10 users (show)

See Also:

Attachments
Patch (14.51 KB, patch)
2022-05-11 20:45 PDT, Matt Woodrow 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch (16.12 KB, patch)
2022-05-12 17:43 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Patch (14.56 KB, patch)
2022-05-12 17:47 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-05-11 16:02:08 PDT 
<rdar://92054921>

Flightaware is serialising matrix() style properties, and expecting the string comparison to match one created using JS string concatenation.

This was previously true, but regressed when bug 218880 changed CSS serialisation to match the spec.

We should detect flightaware and use the old serialisation, until the site can be fixed.
Comment 1 Matt Woodrow 2022-05-11 20:45:10 PDT 
Created attachment 459206 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-05-12 17:19:51 PDT 
Comment on attachment 459206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459206&action=review

> Source/WebCore/css/CSSValue.h:280
> +    mutable unsigned m_cachedCSSTextUsesQuirk : 1;

I think this needs to say what the quirk is, something like m_cachedCSSTextUsesLegacyPrecision or something.
Comment 3 Matt Woodrow 2022-05-12 17:43:54 PDT 
Created attachment 459263 [details]
Patch
Comment 4 Matt Woodrow 2022-05-12 17:47:56 PDT 
Created attachment 459265 [details]
Patch
Comment 5 EWS 2022-05-12 18:50:43 PDT 
Committed r294138 (250508@main): <https://commits.webkit.org/250508@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459265 [details].