Bug 240319 - TextBoxPainter::paintForeground: painting text with no marking/decoration should be simple
Summary: TextBoxPainter::paintForeground: painting text with no marking/decoration sho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-11 15:24 PDT by zalan
Modified: 2022-05-12 17:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2022-05-11 15:32 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.13 KB, patch)
2022-05-12 06:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2022-05-12 13:38 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2022-05-12 15:30 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-05-11 15:24:42 PDT 
ssia
Comment 1 zalan 2022-05-11 15:32:01 PDT 
Created attachment 459185 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-05-11 15:37:37 PDT 
Comment on attachment 459185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459185&action=review

> Source/WebCore/rendering/TextBoxPainter.cpp:191
> +            , StyledMarkedText::computeStyleForUnmarkedMarkedText(m_renderer, lineStyle, m_isFirstLine, m_paintInfo) });

comma on previous line
Comment 3 zalan 2022-05-12 06:37:31 PDT 
Created attachment 459225 [details]
Patch
Comment 4 zalan 2022-05-12 13:38:30 PDT 
Created attachment 459247 [details]
Patch
Comment 5 zalan 2022-05-12 15:30:14 PDT 
Created attachment 459253 [details]
Patch
Comment 6 EWS 2022-05-12 17:32:42 PDT 
Committed r294128 (250505@main): <https://commits.webkit.org/250505@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459253 [details].
Comment 7 Radar WebKit Bug Importer 2022-05-12 17:33:17 PDT 
<rdar://problem/93212498>