Bug 240318 – [WebAuthn] Clean up WebAuthenticationModern and WebAuthnProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[[e-mail]]

These are no longer necessary for ToT.


Previously landed in https://bugs.webkit.org/show_bug.cgi?id=239073, but was rolled out.

[Radar WebKit Bug Importer]

<rdar://problem/93130490>

[[e-mail]]

Created attachment 459183 [details]
Patch

[Brent Fulgham]

Comment on attachment 459183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459183&action=review

So much cleanup! r=me

> Tools/ChangeLog:-1977
> -        (TestWebKitAPI::WebCore::webAuthenticationModernExperimentalFeature): Deleted.

We don't need this ChangeLog comment removal

> Tools/ChangeLog:2011
> +        (TestWebKitAPI::WebCore::webAuthenticationModernExperimentalFeature): Deleted.

This seems to be in the wrong part of the file (is perhaps a dupe of the 5/11 comment)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:-1437
> -}

Are these two tests really not needed anymore? It doesn't seem like disallowing the local authenticator is specifically related to the WebAuthn process, is it?

[Brent Fulgham]

It doesn't seem like the Mac-AS-debug-wk2 failures are related. I have re-ran them.

[[e-mail]]

(In reply to Brent Fulgham from comment #3)
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:-1437
> > -}
> 
> Are these two tests really not needed anymore? It doesn't seem like
> disallowing the local authenticator is specifically related to the WebAuthn
> process, is it?

These tests are from when the WebAuthenticationPanel used a UI delegate method (decidePolicyForLocalAuthenticator) to ask if using the platform authenticator is permitted. This is superseded by requestLAContextForUserVerification, which effectively does the same thing, but does not return ExceptionData { UnknownError, "Disallow local authenticator."_s } (the standard request cancelled error is used).

[[e-mail]]

Pull request: https://github.com/WebKit/WebKit/pull/744

[EWS]

Committed r294438 (250716@main): <https://commits.webkit.org/250716@main>

Reviewed commits have been landed. Closing PR #744 and removing active labels.