RESOLVED FIXED 240317
TextBoxPainter::paintBackground should bail out early when nothing to paint 
https://bugs.webkit.org/show_bug.cgi?id=240317
Summary TextBoxPainter::paintBackground should bail out early when nothing to paint
zalan
Reported 2022-05-11 14:23:16 PDT
ssia
Attachments
Patch (3.67 KB, patch)
2022-05-11 14:31 PDT, zalan 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.70 KB, patch)
2022-05-11 14:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.09 KB, patch)
2022-05-11 19:45 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.10 KB, patch)
2022-05-11 19:51 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.10 KB, patch)
2022-05-11 19:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-05-11 14:31:49 PDT
Created attachment 459182 [details] Patch
zalan
Comment 2 2022-05-11 14:55:34 PDT
Created attachment 459184 [details] Patch
Simon Fraser (smfr)
Comment 3 2022-05-11 15:03:40 PDT
Comment on attachment 459182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459182&action=review > Source/WebCore/rendering/TextBoxPainter.cpp:140 > + if (m_document.hasHighlightRegister()) Maybe "has highlight register and has a non-zero number of highlights"?
zalan
Comment 4 2022-05-11 19:45:55 PDT
Created attachment 459203 [details] Patch
Simon Fraser (smfr)
Comment 5 2022-05-11 19:47:56 PDT
Comment on attachment 459203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459203&action=review > Source/WebCore/dom/Document.cpp:2891 > + return (m_highlightRegister && !m_highlightRegister->isEmpty()) || (m_fragmentHighlightRegister && !m_fragmentHighlightRegister->isEmpty()) I'd wrap the || ... onto a new line, indented. > Source/WebCore/dom/Document.cpp:2893 > + || (m_appHighlightRegister && m_appHighlightRegister->isEmpty()) Indent this line
zalan
Comment 6 2022-05-11 19:51:09 PDT
Created attachment 459204 [details] Patch
zalan
Comment 7 2022-05-11 19:54:03 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 459203 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459203&action=review > > > Source/WebCore/dom/Document.cpp:2891 > > + return (m_highlightRegister && !m_highlightRegister->isEmpty()) || (m_fragmentHighlightRegister && !m_fragmentHighlightRegister->isEmpty()) > > I'd wrap the || ... onto a new line, indented. > > > Source/WebCore/dom/Document.cpp:2893 > > + || (m_appHighlightRegister && m_appHighlightRegister->isEmpty()) > > Indent this line oops
zalan
Comment 8 2022-05-11 19:55:24 PDT
Created attachment 459205 [details] Patch
EWS
Comment 9 2022-05-12 06:13:32 PDT
Committed r294099 (250484@main): <https://commits.webkit.org/250484@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459205 [details].
Radar WebKit Bug Importer
Comment 10 2022-05-12 06:14:13 PDT
<rdar://problem/93170251>
Brent Fulgham
Comment 11 2022-06-23 16:50:05 PDT
*** Bug 239986 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.