Bug 240315 - Mail compose: right clicking an image attachment selects it
Summary: Mail compose: right clicking an image attachment selects it
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
Keywords: InRadar
Depends on: 240381
  Show dependency treegraph
Reported: 2022-05-11 13:37 PDT by Kate Cheney
Modified: 2022-05-13 07:20 PDT (History)
7 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2022-05-11 13:37:57 PDT
Mail compose: right clicking an image attachment selects it
Comment 1 Kate Cheney 2022-05-11 14:58:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/593
Comment 2 EWS 2022-05-12 11:23:41 PDT
Committed r294113 (250494@main): <https://commits.webkit.org/250494@main>

Reviewed commits have been landed. Closing PR #593 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-12 11:24:13 PDT
Comment 4 Alexey Proskuryakov 2022-05-12 18:14:01 PDT
What was the motivation for this change? AFAICT context click always selects its text target on macOS, and it also always selects an image in editable content. 

We had the same behavior as TextEdit, and no longer do.

Also, the commit message looks malformed.
Comment 5 Alexey Proskuryakov 2022-05-12 18:16:30 PDT
I see some discussion in the PR, so CC'ing folks who participated in it.

That discussion doesn't appear to answer my question.
Comment 6 Wenson Hsieh 2022-05-12 18:26:59 PDT
The motivation was to make right clicking an image in Mail compose *not* select the image. This is the behavior of legacy WebKit compose, and the behavior of WebKit2 compose (which selects images when right-clicking) is a regression.

I had incorrectly thought that this change was aligning us to AppKit (TextEdit/NSTextView) behavior. Upon further testing, this does not appear to be the case — when right clicking an image in TextEdit, the image is indeed selected, but the selection is painted *behind* the image rather than in the foreground, which makes it appear as if the image isn't selected.
Comment 7 WebKit Commit Bot 2022-05-13 07:20:25 PDT
Re-opened since this is blocked by bug 240381