REOPENED 240315
Mail compose: right clicking an image attachment selects it 
https://bugs.webkit.org/show_bug.cgi?id=240315
Summary Mail compose: right clicking an image attachment selects it
Kate Cheney
Reported 2022-05-11 13:37:57 PDT
Mail compose: right clicking an image attachment selects it
Attachments
Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2022-05-11 14:58:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/593
EWS
Comment 2 2022-05-12 11:23:41 PDT
Committed r294113 (250494@main): <https://commits.webkit.org/250494@main> Reviewed commits have been landed. Closing PR #593 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-05-12 11:24:13 PDT
<rdar://problem/93189849>
Alexey Proskuryakov
Comment 4 2022-05-12 18:14:01 PDT
What was the motivation for this change? AFAICT context click always selects its text target on macOS, and it also always selects an image in editable content. We had the same behavior as TextEdit, and no longer do. Also, the commit message looks malformed.
Alexey Proskuryakov
Comment 5 2022-05-12 18:16:30 PDT
I see some discussion in the PR, so CC'ing folks who participated in it. That discussion doesn't appear to answer my question.
Wenson Hsieh
Comment 6 2022-05-12 18:26:59 PDT
The motivation was to make right clicking an image in Mail compose *not* select the image. This is the behavior of legacy WebKit compose, and the behavior of WebKit2 compose (which selects images when right-clicking) is a regression. I had incorrectly thought that this change was aligning us to AppKit (TextEdit/NSTextView) behavior. Upon further testing, this does not appear to be the case — when right clicking an image in TextEdit, the image is indeed selected, but the selection is painted *behind* the image rather than in the foreground, which makes it appear as if the image isn't selected.
WebKit Commit Bot
Comment 7 2022-05-13 07:20:25 PDT
Re-opened since this is blocked by bug 240381
Note You need to log in before you can comment on or make changes to this bug.