Bug 240309 - Remove a first bit of unused plug-in code
Summary: Remove a first bit of unused plug-in code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-11 09:39 PDT by Darin Adler
Modified: 2022-05-19 20:39 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2022-05-11 09:39:23 PDT
We can remove a lot of code. Instead of a plug-in mechanism, we just need enough for the PDF support built into WebKit. This will be a first patch to remove it.
Comment 1 Yusuke Suzuki 2022-05-11 11:16:10 PDT
I’m excited about this since it can pave the way to finally removing RuntimeArray JSCell which introduced a lot of weird special code in JSC (RuntimeArray looks like a JSArray, but not a real JSArray, it caused a lot of trouble in DFG optimization etc. so far).
Comment 2 Darin Adler 2022-05-11 18:59:03 PDT
I’m trying to take it slow; last time I removed too much all at once.
Comment 3 Darin Adler 2022-05-11 19:19:15 PDT
Seems like legacy WebKit also has a way to make plug-ins using Objective-C and it’s not clear we deprecated that yet.
Comment 4 Radar WebKit Bug Importer 2022-05-18 09:40:14 PDT
<rdar://problem/93508964>
Comment 5 Darin Adler 2022-05-18 20:01:28 PDT
Pull request: https://github.com/WebKit/WebKit/pull/752
Comment 6 EWS 2022-05-19 20:39:51 PDT
Committed r294526 (250781@main): <https://commits.webkit.org/250781@main>

Reviewed commits have been landed. Closing PR #752 and removing active labels.