Bug 240305 - REGRESSION(r291038) [GTK][WPE] Fix build without remote inspector
Summary: REGRESSION(r291038) [GTK][WPE] Fix build without remote inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-11 06:38 PDT by Olivier Blin
Modified: 2022-05-12 07:29 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.12 KB, patch)
2022-05-11 06:50 PDT, Olivier Blin 		no flags Details | Formatted Diff | Diff
Patch (5.07 KB, patch)
2022-05-12 04:06 PDT, Olivier Blin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2022-05-11 06:38:54 PDT 
GLib ports do not build anymore without remote inspector after r291038.
Comment 1 Olivier Blin 2022-05-11 06:50:20 PDT 
Created attachment 459163 [details]
Patch
Comment 2 Michael Catanzaro 2022-05-11 07:59:23 PDT 
Comment on attachment 459163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459163&action=review

> Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:126
>      parameters.inspectorServerAddress = Inspector::RemoteInspector::inspectorServerAddress();

Would be nice to define it conditionally, too, so it doesn't exist at all except when ENABLE(REMOTE_INSPECTOR) is defined. Just a bit more robust to future changes, in case leaving it uninitialized is not OK in the future.
Comment 3 Olivier Blin 2022-05-12 04:06:28 PDT 
Created attachment 459220 [details]
Patch
Comment 4 EWS 2022-05-12 07:28:56 PDT 
Committed r294103 (250488@main): <https://commits.webkit.org/250488@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459220 [details].