Bug 240293 – [WinCairo] Support file downloads

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yury Semikhatsky]

[WinCairo] Support file downloads

[Yury Semikhatsky]

Created attachment 459142 [details]
Patch

[Fujii Hironori]

Comment on attachment 459142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459142&action=review

> Source/WebKit/ChangeLog:8
> +        Hooked up Curl calls to Download callbacks. Added basix support for

basix → basic

> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:194
> +            FileSystem::writeToFile(m_downloadDestinationFile, segment.data(), segment.size());

Why do you ignore the return value of writeToFile?

[Yury Semikhatsky]

Comment on attachment 459142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459142&action=review

>> Source/WebKit/ChangeLog:8
>> +        Hooked up Curl calls to Download callbacks. Added basix support for
> 
> basix → basic

Done.

>> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:194
>> +            FileSystem::writeToFile(m_downloadDestinationFile, segment.data(), segment.size());
> 
> Why do you ignore the return value of writeToFile?

Fixed. Added error handling.

[Yury Semikhatsky]

Created attachment 459177 [details]
Patch

[Fujii Hironori]

Comment on attachment 459177 [details]
Patch

LGTM

[EWS]

Committed r294077 (250472@main): <https://commits.webkit.org/250472@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459177 [details].

[Radar WebKit Bug Importer]

<rdar://problem/93131394>

[Don Olmstead]

*** Bug 234887 has been marked as a duplicate of this bug. ***