Bug 240292 – [LIBPAS] Add extra assert information to malloc enumeration API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Justin Michaud]

[LIBPAS] Add extra assert information to malloc enumeration API

[Justin Michaud]

Created attachment 459138 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 459138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459138&action=review

r=me with comments.

> Source/bmalloc/ChangeLog:7
> +

Can you describe what is extra compared to PAS_ASSERT_WITH_DETAIL in ChangeLog? (feature putting values to specific registers before crashing etc.).
And let's also mention to PAS_DEBUG_LOG_TO_SYSLOG's extension.

> Source/bmalloc/libpas/src/libpas/pas_log.c:97
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wformat-nonliteral"

Use `PAS_IGNORE_WARNINGS_BEGIN("format-nonliteral")`

> Source/bmalloc/libpas/src/libpas/pas_log.c:99
> +#pragma clang diagnostic pop

Put PAS_IGNORE_WARNINGS_END

> Source/bmalloc/libpas/src/libpas/pas_utils.c:94
> +        pas_crash_with_info_impl((uint64_t) format, 0, 0, 0, 0, 0, 0);

Let's remove space between (uint64_t) format

> Source/bmalloc/libpas/src/libpas/pas_utils.c:110
> +    pas_crash_with_info_impl((uint64_t) filename, line, (uint64_t) function, (uint64_t) expression, 0xbeefbff0, 42, 1337);

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_utils.c:117
> +    pas_crash_with_info_impl((uint64_t) filename, line, (uint64_t) function, (uint64_t) expression, extra, 1337, 0xbeef0bff);

Ditto.

[Justin Michaud]

Created attachment 459140 [details]
Patch

[Justin Michaud]

Comment on attachment 459140 [details]
Patch

I think I've waited long enough for api-ios.

[EWS]

Committed r294214 (250572@main): <https://commits.webkit.org/250572@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459140 [details].

[Radar WebKit Bug Importer]

<rdar://problem/93298917>

[Yusuke Suzuki]

Committed r294220 (250578@trunk): <https://commits.webkit.org/250578@trunk>

[Yusuke Suzuki]

Comment on attachment 459140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459140&action=review

> Source/bmalloc/libpas/src/libpas/pas_local_allocator_config_kind.h:86
>  #include "pas_segregated_page_config_kind.def"

I've reverted this file's change because these code can be used in the hot path, and we should keep things all inlined.
So, if we would like to collect more information, let's check things & add assertion in enumeration side :)
They are super cold code, so any perf problem does not matter.