Bug 240285 - [Xcode] Fix dependency cycles caused by Safari header imports
Summary: [Xcode] Fix dependency cycles caused by Safari header imports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-10 12:16 PDT by Elliott Williams
Modified: 2022-05-31 14:48 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-05-10 12:16:18 PDT 
There are a number of locations where we include an internally-available header produced by a target that depends on WebKit. These _usually_ don't fail the build when the build order in manually specified, but cause problems when building with "dependency order" target-level parallelism. They are true cycles, so we need to fix them.
Comment 1 Elliott Williams 2022-05-10 13:59:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/581
Comment 2 Elliott Williams 2022-05-10 14:20:56 PDT 
rdar://90491841
Comment 3 EWS 2022-05-31 14:48:27 PDT 
Committed r295067 (251162@main): <https://commits.webkit.org/251162@main>

Reviewed commits have been landed. Closing PR #581 and removing active labels.