Bug 240275 - Introduce a canvas-drawImage specific method to get a NativeImage from a video element
Summary: Introduce a canvas-drawImage specific method to get a NativeImage from a vide...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-10 04:50 PDT by youenn fablet
Modified: 2022-05-11 10:22 PDT (History)
14 users (show)

See Also:

Attachments
Patch (7.65 KB, patch)
2022-05-10 05:29 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2022-05-11 00:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-05-10 04:50:19 PDT 
Introduce a canvas-drawImage specific method to get a NativeImage from a video element
Comment 1 youenn fablet 2022-05-10 05:29:23 PDT 
Created attachment 459110 [details]
Patch
Comment 2 Sam Weinig 2022-05-10 10:22:22 PDT 
Comment on attachment 459110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459110&action=review

> Source/WebCore/platform/graphics/MediaPlayer.h:479
> +    RefPtr<NativeImage> currentNativeImageForCanvasDrawing();

The functions above use the phrasing "ForCurrentTime" rather than just "current". Would be good to stay consistent here:` nativeImageForCanvasDrawingForCurrentTime()`
Comment 3 youenn fablet 2022-05-11 00:21:44 PDT 
After discussion with Eric, a boolean getter might be a better fit.
Comment 4 youenn fablet 2022-05-11 00:23:27 PDT 
Created attachment 459146 [details]
Patch
Comment 5 EWS 2022-05-11 10:21:48 PDT 
Committed r294057 (250461@main): <https://commits.webkit.org/250461@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459146 [details].
Comment 6 Radar WebKit Bug Importer 2022-05-11 10:22:14 PDT 
<rdar://problem/93112229>